Prevent panic on fuzzer provided string#14405
Merged
Merged
Conversation
The fuzzer has found that providing a <body> tag with an attribute to PostProcess causes a panic. This PR removes any rendered html or body tags from the output. Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
alternate-fuzz-fix
branch
from
210cadb to
29289d4
Compare
zeripath
commented
Jan 20, 2021
GiteaBot
added
the
lgtm/need 2
zeripath
commented
Jan 20, 2021
Signed-off-by: Andrew Thornton <art27@cantab.net>
zeripath
force-pushed
the
alternate-fuzz-fix
branch
from
e0dd124 to
3cb8f9f
Compare
Contributor
Author
|
@lunny - the body wraparound is necessary. |
Signed-off-by: Andrew Thornton <art27@cantab.net>
6543
approved these changes
Jan 20, 2021
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Jan 20, 2021
GiteaBot
added
lgtm/done
6543
pushed a commit
to 6543-forks/gitea
that referenced
this pull request
Jan 20, 2021
* Prevent panic on fuzzer provided string The fuzzer has found that providing a <body> tag with an attribute to PostProcess causes a panic. This PR removes any rendered html or body tags from the output. Signed-off-by: Andrew Thornton <art27@cantab.net> * Placate lint * placate lint again Signed-off-by: Andrew Thornton <art27@cantab.net> * minor cleanup Signed-off-by: Andrew Thornton <art27@cantab.net>
Member
|
Backport: #14409 |
lafriks
pushed a commit
that referenced
this pull request
Jan 20, 2021
* Prevent panic on fuzzer provided string The fuzzer has found that providing a <body> tag with an attribute to PostProcess causes a panic. This PR removes any rendered html or body tags from the output. Signed-off-by: Andrew Thornton <art27@cantab.net> * Placate lint * placate lint again Signed-off-by: Andrew Thornton <art27@cantab.net> * minor cleanup Signed-off-by: Andrew Thornton <art27@cantab.net> Co-authored-by: zeripath <art27@cantab.net>
6543
added
the
topic/security
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuzzer has found that providing a tag with an attribute to
PostProcess causes a panic. This PR removes any rendered html or body
tags from the output.
Replaces #14402
Signed-off-by: Andrew Thornton art27@cantab.net